Make space in metadata optional for empty values #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning behind this change lays in tus/tus-js-client#41, to summarize:
If we have a metadata key-value pair with an empty value, we will get a value for the
Upload-Metadataheader such as:"empty_value ". Notice the space on the end of the string which normally separates the key and value. Usually, it should not be a problem that a header value ends with a space but in reality this is different, particularly in browsers.For example, Chrome simply trims headers before sending a HTTP request to remove whitespace at the ends (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/fetch/FetchUtils.cpp?sq=package:chromium&rcl=1471966011&l=209). On the other hand, Safari will refuse to add a header to a request which ends with a space (see request/request#1951 (comment)). Furthermore, such behavior is possibly not limited to browsers.
Basically, in both examples the clients are not able to send empty-valued metadata while being not compatible to the specification. Therefore, I suggest we make the separating space optional if the value is empty to circumvent these issues.
@kvz